Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): use babel-runtime is a dependency (dependencies) #312

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

nickpape
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • [*] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

lib/karma-webpack.js has the following line:

var _toConsumableArray2 = require('babel-runtime/helpers/toConsumableArray');

When using pnpm, the babel-runtime is marked as a devDependency and therefore not included in the node_modules. Hence you get the following error:

27 02 2018 10:54:19.765:ERROR [config]: Invalid config file!
  Error: Cannot find module 'babel-runtime/helpers/toConsumableArray'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (D:\GitRepos\sp-client2\common\temp\node_modules\.onedrive.pkgs.visualstudio.com\karma-webpack\2.0.12\webpack@3.6.0\node_modules\karma-webpack\lib\karma-webpack.js:3:27)

What is the new behavior?

The babel-runtime is installed as a runtime dependency.

Does this PR introduce a breaking change?

  • Yes
  • [*] No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@michael-ciniawsky michael-ciniawsky changed the title babel-runtime is a regular dependency, not a devDependency fix(package): use babel-runtime is a dependency (dependencies) Feb 27, 2018
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky michael-ciniawsky added this to the 2.0.13 milestone Feb 27, 2018
@michael-ciniawsky michael-ciniawsky merged commit c45cdf3 into codymikol:master Feb 27, 2018
@michael-ciniawsky
Copy link
Contributor

Released in v2.0.13 🎉

@michael-ciniawsky
Copy link
Contributor

michael-ciniawsky commented Feb 27, 2018

😱 @nickpape-msft Please sign the CLA or I need to revert this

@michael-ciniawsky michael-ciniawsky removed this from the 2.0.14 milestone Feb 27, 2018
@nickpape
Copy link
Contributor Author

I work at a large company, it will likely take weeks to sign the CLA, but I started the approval process. Perhaps we want to revert and then have someone who has signed the CLA to clean-room this change.

@benedikt-roth
Copy link

@michael-ciniawsky will you revert the change? I would like to know, since we locked the dependency version to 2.0.9 for now. I'd like to unlock it again but do not want it to break if it is going to be reverted in 2.0.14. Thanks for the info and thanks for the fix, Nicholas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants